Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a database or secret on schema commands #498

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Require a database or secret on schema commands #498

merged 6 commits into from
Dec 10, 2024

Conversation

henryfauna
Copy link
Contributor

@henryfauna henryfauna commented Dec 10, 2024

Ticket(s): FE-6215

Problem

  • Running fauna schema status without specifying a database, secret or config/profile errors out.
  • fauna schema status does not accept a dir argument when it should.

Solution

  • Include the common validateDatabaseOrSecret check on the schema command.
  • Include localSchemaOptions in the schema status options.

Result

All schema commands will yell at you if you don't provide a database, secret or profile.

Testing

Added a test.

@henryfauna henryfauna marked this pull request as ready for review December 10, 2024 17:25
@henryfauna henryfauna requested a review from a team as a code owner December 10, 2024 17:25
@ecooper ecooper merged commit 4eed51c into v3 Dec 10, 2024
4 checks passed
@ecooper ecooper deleted the FE-6215 branch December 10, 2024 21:11
@mwilde345 mwilde345 mentioned this pull request Dec 10, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants